Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accelerate -Cadence #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

cadence09
Copy link

No description provided.

.headerLink {
text-decoration: none;
font-size: 200%;
color:#8a4016
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
color:#8a4016
color:#8a4016;

color: #8a4016;
}

@media only screen and (min-width: 768px){
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that you made the page responsive ! People may be looking at your portfolio on any kind of device! Here is a great resource for media queries !

Comment on lines +58 to +70
.characteristics{
display:flex;
flex-direction: column;
/* float:right; */
margin-right: 5%;


}

.characteristics{
font-size: 50px;
justify-content: space-between;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are referencing the same element and can be combined.

Comment on lines +23 to +26
<p>
I love to living in San Francisco Bay Area, it locates in West Coast and I can view the beautiful Pacific Ocean.
I often go hiking on weekend to see the big ocean and relax myself. I often visit Mori Point Hiking Trail,
it has a very goo good view of Sunset. I can see a clear view.
Copy link

@tgoslee tgoslee Jul 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are a few grammar suggestions for you.

Suggested change
<p>
I love to living in San Francisco Bay Area, it locates in West Coast and I can view the beautiful Pacific Ocean.
I often go hiking on weekend to see the big ocean and relax myself. I often visit Mori Point Hiking Trail,
it has a very goo good view of Sunset. I can see a clear view.
<p>
I love to live in San Francisco Bay Area, it's located on the West Coast and I can view the beautiful Pacific Ocean.
I often go hiking on the weekend to see the big ocean and relax. I often visit Mori Point Hiking Trail,
it has a very good view of Sunset. I can see a clear view.

Comment on lines +25 to +29
<p>Hi, my name is Cadence</p>
<h1>I Build What People Need</h1>
<p>I care about what helps people.</p>
<p> I focus on what people need and build applications that empower and impact people's life</p>
</div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love these short statements. They are concise and clear.

Comment on lines +32 to +34
<p class=characteristic>Love<span> what you do</span></p>
<p class=characteristic>Care<span> what impact to people life</span></p>
<p class=characteristic>Focus<span> what your motivation</span></p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you have quotation marks around the class attribute. Also, the parent element would normally have a different class name than the child elements.

Suggested change
<p class=characteristic>Love<span> what you do</span></p>
<p class=characteristic>Care<span> what impact to people life</span></p>
<p class=characteristic>Focus<span> what your motivation</span></p>
<p class="characteristic">Love<span> what you do</span></p>
<p class="characteristic">Care<span> what impact to people life</span></p>
<p class="characteristic">Focus<span> what your motivation</span></p>

Comment on lines +20 to +35
<section>
<h1> Build Web Applications to Mobile Applications</h1>
<div class="viewing-party">
<h2>Swap meet</h2>
<p>Swap meet is built to allow each person to swap one of their things with anther person's things</p>
<a href="https://github.com/cadence09/task-list-api">Swap Meet</a>
<p>Techs skills: Python</p>
</div>
<div class="task-api">
<h2>Task List Api</h2>
<p>Task List Api is built to allow users to organze tasks. Users can create, see, update, and delete task.</p>
<a href="https://github.com/cadence09/task-list-api">Task API</a>
<p>Techs skills: Python, Postgres, Flask, Slack API </p>
</div>

</section>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep adding your projects! You have been working on great things!

Comment on lines +15 to +18
<a class="headerLink" href="index.html">Home</a>
<a class="headerLink" href="about.html">About</a>
<a class="headerLink" href="portfolio.html">Portfolio</a>
<a class="headerLink" href="hobby.html">Hobby</a>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use jquery to make your nav bar reusable on each html page. Here is an example your nav info would be stored in nav.html and then a few lines of code would be added to each html file.

@tgoslee
Copy link

tgoslee commented Jul 5, 2021

I enjoyed the layout and color scheme of your portfolio. It was clean, clear, and concise. I left some comments on how to make your header reusable, grammar, and cleaning up CSS. Great Job, Cadence !

@tgoslee tgoslee closed this Jul 5, 2021
@tgoslee tgoslee reopened this Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants